search

ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

Improved Docs for iOS Projects? #233

Closed iainsmith closed 6 months ago

iainsmith commented 8 months ago

Thank you for producing such a wonderful package. I recently wanted to run some benchmarks that have a hard UIKit dependency, and I hit some issues when following the documentation which assumes a mac/linux environment (unless I missed something).

Given the prevalence of iOS swift code, having some additional documentation for this case would help get iOS teams onboarded.

hassila commented 8 months ago

We'd be happy to take a PR if there's anything specific that needs to be taken into consideration- we currently don't work on iOS so hard to document for us. Any improvements appreciated.

hassila commented 8 months ago

More concretely what was the problem?

hassila commented 8 months ago

@ktoso seems you commented in context of some DA system, this issue is in context of Benchmark docs, probably ended up in wrong issue?

ktoso commented 8 months ago

Oh boy, ignore me -- I wrongly assumed this comment was in the distributed system package 😅 Let me remove the comment, it's just noise :)

hassila commented 8 months ago

@iainsmith did you have any concrete suggestions on improvements? As mentioned above we don't use iOS ourselves...

hassila commented 6 months ago

@iainsmith I tried to add the relevant iOS ifdefs here, not sure if that is enough for it to work as expected, but give it a try. Happy to take any other concrete suggestions on improvements, but as mentioned we don't do iOS so hard for us to know what's missing really... :-)

https://github.com/ordo-one/package-benchmark/releases/tag/1.23.4