search

org-arl / SignalAnalysis.jl

Signal analysis toolbox for Julia
MIT License
42 stars 11 forks source link

fix(*): replace seconds with s #11

Closed ymtoo closed 4 years ago

ymtoo commented 4 years ago 
using InteractiveViz
using SignalAnalysis 

fs = 4800
N = 48000
x = randn(N)

iplot(signal(x, fs))
ispecgram(signal(x, fs))

Before the PR: timeseries-before specgram-before

After the PR: timeseries-after specgram-after

mchitre commented 4 years ago

What's wrong with "seconds"?

ymtoo commented 4 years ago

By default, the plots of iplot and ispecgram should have the same x-axis labels, i.e., "Time (s)". Since "Time (ms)" has been used for short time data, "Time (s)" could be a better choice than "Time (seconds)".

mchitre commented 4 years ago

Fair!