Fix uninitialized variables + clang-tidy warnings

ori-drs / allan_variance_ros

ROS compatible tool to generate Allan Deviation plots

BSD 3-Clause "New" or "Revised" License

496 stars 87 forks source link

Fix uninitialized variables + clang-tidy warnings #7

Closed mintar closed 3 years ago

mintar commented 3 years ago

The only really important commit is the last one ("Initialize all variables"). This fixes a bug caused by lastImuTime_ not being initialized, leading to all IMU messages being skipped with error message "IMU message before last imu time."

The remaining commits just fix some clang-tidy warnings and are more aesthetic than functional.

Please review each commit separately.

mintar commented 3 years ago

FYI: I've rebased the PR onto the current master to resolve merge conflicts.