fix return value of method_name in case typename contains a *

orocos-toolchain / orogen

Code generator for components and type handling in Rock - the Robot Construction Kit - and the Orocos Toolchain

http://rock-robotics.org

Other

4 stars 35 forks source link

fix return value of method_name in case typename contains a * #128

Closed 2maz closed 4 years ago

2maz commented 4 years ago

This happens if for example Vector<Foo *> is given as opaque.

Extracted from #89 with added tests

doudou commented 4 years ago

Would you consider adding a build test in rock-build-tests ?

The process would be to:

create a new orogen project that uses the 'problematic' types (e.g. https://github.com/rock-core/build_tests-orogen-default_extensions)
add it to the rock-build-tests buildconf (https://github.com/rock-core/rock.build-tests-buildconf)

This makes sure that an orogen project that uses this types will actually compile.

doudou commented 4 years ago

Hi @2maz ... Just realized that I followed the way we handle PRs at TideWise. We're only approving them, the author has to do the merge. Just to say that I'm OK to merge this now.

2maz commented 4 years ago

For tests see rock-core/rock.build-tests-buildconf#7