updating toolchain-2.9 to include metaruby fix branch

orocos-toolchain / orogen

Code generator for components and type handling in Rock - the Robot Construction Kit - and the Orocos Toolchain

http://rock-robotics.org

Other

4 stars 35 forks source link

updating toolchain-2.9 to include metaruby fix branch #143

Closed dustingooding closed 3 years ago

dustingooding commented 3 years ago

merging master into toolchain-2.9, to grab commits from merged https://github.com/orocos-toolchain/orogen/pull/140

meyerj commented 3 years ago

I am sorry. Already merged it in 8bd5ae96214102068e53d990eb64fad23d07baa6 after I saw your comment in https://github.com/orocos-toolchain/orogen/pull/140#issuecomment-768375365 and only then realized that this pull request does exactly the same. So I am fine with merging it, but it is basically a no-op now. Typically I always pulled changes from master into the toolchain-2.x branches in the past, without an extra PR.

dustingooding commented 3 years ago

No worries! Thanks @meyerj

dustingooding commented 3 years ago

@meyerj I think https://github.com/orocos-toolchain/orocos_toolchain/issues/44 might still need to be fixed. i think orocos_toolchain's orogen submodule commit needs to be updated. i just tried building from source and it failed.