search

orocos-toolchain / orogen

Code generator for components and type handling in Rock - the Robot Construction Kit - and the Orocos Toolchain
http://rock-robotics.org
Other
4 stars 35 forks source link

Forward cflags of loaded headers files to load options #95

Closed maltewi closed 7 years ago

maltewi commented 7 years ago

This makes orogen eventually pass cflags to typegen. This was discussed at orocos-toolchain/typelib#99 when thinking about how to tell typegen which cpp copiler version to use (eg. -std=c++11).

doudou commented 7 years ago

I've tested this against the build tests I wrote a few weeks ago. It didn't pass. It seems that typelib does not pass the rawflags option to the preprocessor stage, only to the import stage.

Moreover, in our case here we should limit the rawflags to the rawflags-only-other IMO, since includes and defines are already passed by separate options. I've created the raw_cflags_only_other (and other missing raw_ variants) in this utilrb PR. Could you use that instead ?

doudou commented 7 years ago

I've done the work ... #97

Merged the utilrb PR and created a corresponding typelib PR (https://github.com/orocos-toolchain/typelib/pull/102)

Could you have a look ? I've invited you to be a collaborator on this repo so that you can work on the branch. I've pushed it here because I didn't have access to yours.