orthecreedence / wookie

Asynchronous HTTP server in common lisp
http://wookie.lyonbros.com/
MIT License
189 stars 19 forks source link

Does not build - urlencode api issue? #85

Closed quicklisp closed 6 years ago

quicklisp commented 6 years ago

I get this:

; file: /home/quicklisp/quicklisp-controller/dist/build-cache/wookie/f61e1c13eb11deacb1a3e8e556eb21aa9cb2e228/wookie-20181011-git/parser.lisp
; in: DEFUN SETUP-PARSER
;     (DO-URLENCODE:URLDECODE (QURI.URI:URI-PATH WOOKIE::PARSED-URI) :LENIENTP T)
; 
; caught WARNING:
;   :LENIENTP is not a known argument keyword.
orthecreedence commented 6 years ago

Can you try this again?

quicklisp commented 6 years ago

Doesn't help, sorry, since it's a compile-time warning, not a runtime warning.

quicklisp commented 6 years ago

You can see the problem if you try with sbcl and use :verbose t on quickloading.

orthecreedence commented 6 years ago

Ok, what about now?

quicklisp commented 6 years ago

Sorry, SBCL is too smart for that and can tell the call is to the same function as before.

orthecreedence commented 6 years ago

God damnit. Worked wth CCL. Do you think something like

(let* ((fn (funcall (lambda () 'do-urlencode:urldecode)))
       (path (funcall 'fn ...))
...)

has a chance?

quicklisp commented 6 years ago

Not sure, sorry. How about just leaving off the keyword argument entirely, since it is not available on the new API anyway?

orthecreedence commented 6 years ago

Because if someone is using the old version without the keyword, the url parsing breaks quite often. But yeah, might as well just take it out.

orthecreedence commented 6 years ago

K should be fixed. Thanks for the help.