Open nsklikas opened 1 month ago
Looks like the conformity tests are failing because it tries to use this version of fosite on hydra master
. But they pass on the hydra PR with this version of fosite. Changes are needed on the hydra config DefaultProvider
object, how should we fix this?
Looks like the conformity tests are failing because it tries to use this version of fosite on hydra
master
. But they pass on the hydra PR with this version of fosite. Changes are needed on the hydra configDefaultProvider
object, how should we fix this?
You should be able to change the target commit in the CI file to target your PR in hydra, which should make the tests pass
Thank you for the reviews.
I reverted the refactor on the oauth2 handlers and tried to address all the comments. Also pinned the ci to use hydra from the PR branch and now the tests pass. Please have another go.
Related Design Document
Implements RFC 8628.
Checklist
Further comments
This PR is based on the work done on https://github.com/ory/fosite/pull/701, by @supercairos and @BuzzBumbleBee. That PR was based on an older version of fosite and was missing some features/tests.
Comments:
go.uber.org/mock/gomock
(github.com/golang/mock/gomock
is deprecated)AuthorizeExplicitGrantHandler
to generalize it to reduce code duplication