ory / hydra

The most scalable and customizable OpenID Certified™ OpenID Connect and OAuth Provider on the market. Become an OpenID Connect and OAuth2 Provider over night. Broad support for related RFCs. Written in Go, cloud native, headless, API-first. Available as a service on Ory Network and for self-hosters.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=hydra
Apache License 2.0
15.64k stars 1.5k forks source link

chore: remove redundant logic #3831

Closed longhutianjie closed 2 months ago

longhutianjie commented 2 months ago

both branches in if statement have same body

Checklist

Further Comments

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.49%. Comparing base (d85c69f) to head (49a06c5). Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3831 +/- ## ========================================== - Coverage 74.61% 74.49% -0.13% ========================================== Files 140 140 Lines 10579 10609 +30 ========================================== + Hits 7894 7903 +9 - Misses 2163 2184 +21 Partials 522 522 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sajjon commented 2 months ago

[!CAUTION] GH user longhutianjie is performing a supply chain attack! 🚫 BLOCK user immediatly and report him to Github 🚫

The first step is getting rid of "first time contributor" status.

The user has manually added the message "Signed-off-by: " to make the commit look more trust worthy. User has opened similar PRs in all these other repos in within the same hour:

Furthermore I'm pretty sure this is the same person or group as github.com/vivoxfold3, who tried performing the attack against these repos, with the exact same style: Manually adding the message "Signed-off-by: " and making trivial contributions to many crypto libs within the same hour:

aeneasr commented 2 months ago

Thank you, reported.