ory / k8s

Kubernetes Helm Charts for the ORY ecosystem.
https://k8s.ory.sh/helm
Apache License 2.0
335 stars 258 forks source link

feat: added configuration for TLS enabled hydra admin services #636

Closed dwilson1988 closed 1 year ago

dwilson1988 commented 1 year ago

This pull request adds the ability to configure hydra-maester to point to a hydra admin endpoint that has TLS enabled. Previous to this PR, "http" was hard-coded in the admin host, causing HTTP 400 responses when talking to a hydra admin endpoint with TLS enabled. Furthermore, this PR adds the ability to add volume/volumeMounts to the deployment to add CA certs.

This simply adds in a few missing command line options from hydra-maester.

Checklist

dwilson1988 commented 1 year ago

Hi there! Good catch, hardcoded is almost always bad :D Just a few general remarks from my side :)

Thanks for the review! I've made the requested changes, let me know if there's anything else you'd like me to change!