ory / k8s

Kubernetes Helm Charts for the ORY ecosystem.
https://k8s.ory.sh/helm
Apache License 2.0
335 stars 258 forks source link

Kratos selfservice UI incorrectly supports `BASE_PATH` #651

Closed emmenko closed 1 year ago

emmenko commented 1 year ago

Preflight checklist

Ory Network Project

No response

Describe the bug

The kratos-selfservice-ui-node application allows to configure a base path via the environment variable BASE_PATH.

https://github.com/ory/kratos-selfservice-ui-node/blob/9ad2556d104f5ee92e75a1874c93fe9ad2abdf1b/src/index.ts#L35

However, the related Helm chart does not support that option.

We can still pass the value as an environment variable with deployment.extraEnv option but the health check probes must be updated as well to support the BASE_PATH (they are hardcoded to /health/alive and /health/ready).

Reproducing the bug

See description above.

To give an example, if I configure the environment variable as

deployment:
  extraEnv:
    BASE_PATH=/auth

The pod won't start because the probe checks fail as it should be /auth/health/ready.

Relevant log output

No response

Relevant configuration

No response

Version

Chart v0.37.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

Kubernetes with Helm

Additional Context

No response