ory / kratos

The most scalable and customizable identity server on the market. Replace your Homegrown, Auth0, Okta, Firebase with better UX and DX. Has all the tablestakes: Passkeys, Social Sign In, Multi-Factor Auth, SMS, SAML, TOTP, and more. Written in Go, cloud native, headless, API-first. Available as a service on Ory Network and for self-hosters.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=kratos
Apache License 2.0
11.33k stars 963 forks source link

fix: code strategy should not reset UI messages when populating login flow (PS-557) #4190

Open splaunov opened 3 weeks ago

splaunov commented 3 weeks ago

This PR fixes an issue when duplicate credentials error added by OIDC strategy into new login flow is lost because code strategy clears all messages when populating login flow.

This is where OIDC strategy adds duplicate credentials error into flow ui messages list: https://github.com/ory/kratos/blob/234b6f2f6435c62b7e161c032b888c4e2b3328d4/selfservice/strategy/oidc/strategy.go#L581-L590

Related issue(s)

Checklist

Further Comments