search

osTicket / osTicket-plugins

Core plugins for osTicket (v1.8+)
GNU General Public License v2.0
148 stars 162 forks source link

Oauth2: Resource Owner Email #265

Closed protich closed 1 year ago

protich commented 1 year ago

This PR re-implements PR #261 to be inline with changes made upstream to support Strict Matching setting.

protich commented 1 year ago

@MarcBanyard - After some thinking - we've decided to revert your commit and focus instead on changing how IMAP/POP protocol handles OAuth2 authentication. This is a better approach because;

1) Removes Application logic from Plugin - we leave the Resource Owner as authorized 2) Makes it possible to use same Token for both fetching (imap/pop) and sending (smtp)

Thanks again,

MarcBanyard commented 1 year ago

@MarcBanyard - After some thinking - we've decided to revert your commit and focus instead on changing how IMAP/POP protocol handles OAuth2 authentication. This is a better approach because;

  1. Removes Application logic from Plugin - we leave the Resource Owner as authorized
  2. Makes it possible to use same Token for both fetching (imap/pop) and sending (smtp)

Thanks again,

No problems, I agree this is a much better way to do this as it simplifies the process for users.