Closed OOF2510 closed 3 years ago
I apologize, I had thought that pull requests were set to the commit at the time of making the PR, not the branch, and did not add commits afterwards, I have created a new branch containing just the changes described in the title and a pull request (#101), with a detailed description, to merge that branch. I had replaced the author
field in package.json
as I plan on maintaining my own fork of this project seprately. I have added the Contributors back to README in my fork. I do not want to merge the master branch of my fork, and that is why I have made #101 to merge only the intended changes. I am fairly new to contributing to open source projects that I don't own and that is why I had made this mistake, once again, I apologize. If you have any issues with #101 please let me know on there!
Thank you for your work but I am going to close this issue as you do not seem to understand how open source works and the proposed changes go far against what I would be willing to merge.
My issues with your changes:
package.json
author
field didn't need to be updated as this project was still authored by me and for the most part is copyright of me. Removing the Contributors section from the README is disrespectful to the people such as yourself who have given their own time to help the project. I personally feel open source thrives off crediting people for the work they did and not pretending it is yours.If you have any questions or would like some help with how to properly contribute to open source or ElectronPlayer specifically feel free to send me an email (it is on my GitHub profile page). If you are new to open source I don't want to scare you away from contributing but these changes aren't up to the standard/ethos of what open source is.