search

oschwald / maxminddb-golang

MaxMind DB Reader for Go
ISC License
597 stars 101 forks source link

unify usage of gocheck #33

Closed elmacnifico closed 8 years ago

elmacnifico commented 8 years ago

I switched all tests over to use gocheck to have a more consistent look and feel.

oschwald commented 8 years ago

I think I'd prefer to go in the other direction and remove the use of gocheck in reader_test.go. gocheck doesn't seem to be under active development, and it is a bit of a pain to use with the standard test tooling.

elmacnifico commented 8 years ago

that would have been my plan b ;) if i have some time today i'll make a pr.

elmacnifico commented 8 years ago

btw how would you feel about using smth like github.com/stretchr/testify/assert to reduce some of the error nil catching

oschwald commented 8 years ago

That'd be great! Testify sounds good.