Update readme.md - Githubissues

irfanerol commented 3 years ago

Fix google-apps-script-samples link - it was changed/broken.

oshliaer commented 3 years ago

Thanks for watching! You're a master!

oshliaer commented 3 years ago

And It's strange because I'm checking all links before publishing with markdown-link-check

 "scripts": {
    ...
    "check": "markdown-link-check -v -p ./readme.md"
  },

And now I can see that the link was broken

[✓] https://github.com/googlesamples/apps-script → Status: 200
[✓] https://github.com/dwyl/html-form-send-email-via-google-script-without-server → Status: 200
[✓] https://github.com/rudimusmaximus/BurningGAS → Status: 200
[✓] https://github.com/andrewroberts/GAS-Framework → Status: 200
[✓] https://github.com/andrewroberts/Assert → Status: 200
[✓] https://github.com/sudtanj/AutoSteamGifts → Status: 200
[✓] https://github.com/bkper/bkper-app → Status: 200

174 links checked.

ERROR: 1 dead links found!
[✖] https://github.com/googleworkspace/google-apps-script-samples → Status: 404
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! google-apps-script-awesome-list@1.0.0 check: `markdown-link-check -v -p ./readme.md`
npm ERR! Exit status 1

Thanks!

irfanerol commented 3 years ago

Oh it's strange indeed, but I didn't know about the markdown-link-check I will definitely use it on my projects :+1:

I've realized 404 when I was digging web for articles. This readme is truly awesome btw, covers pretty much all that I need so far.

oshliaer / google-apps-script-awesome-list

Update readme.md #131