search

osism / issues

This repository is used for bug reports that are cross-project or not bound to a specific repository (or to an unknown repository).
https://www.osism.tech
1 stars 1 forks source link

Create config that avoids / handles high load from cadvisor #59

Closed berendt closed 2 years ago

berendt commented 2 years ago

https://review.opendev.org/c/openstack/kolla-ansible/+/800068 https://review.opendev.org/c/openstack/kolla-ansible/+/797195 <-- revert of 800068

Please check if there is a working solution for 800068 to reduce the load of cAdvisor by default.

osfrickler commented 2 years ago

https://review.opendev.org/c/openstack/kolla-ansible/+/800068 has not been reverted, https://review.opendev.org/c/openstack/kolla-ansible/+/797195 is a revert of https://review.opendev.org/c/openstack/kolla-ansible/+/783887 which was broken. So the load-reducing options should be in place for xena deployments.

berendt commented 2 years ago

Can you please suggest/prepare a ustpream backport to stable/wallaby?

JohnGarbutt commented 2 years ago

The discussion on the patch said no backport, but I don't think that was the correct decision: https://review.opendev.org/c/openstack/kolla-ansible/+/800068

FWIW, I think removing cadvisor on compute nodes, and only having it on controllers is probably a good idea. It can be useful on compute nodes, but its probably not worth the cost. I find very useful on controllers though.

berendt commented 2 years ago

Then we do it as a manual backport for OSISM/SCS. Doesn't matter in the end since we are going to Xena soon.

Cadvisor on compute nodes should be discussed. I think if the load is reduced you can let it run for now and make it optional later.