osl-incubator / sugar

Simplify the usage of containers
https://osl-incubator.github.io/sugar/
BSD 3-Clause "New" or "Revised" License
6 stars 8 forks source link

feat: Add a new key in the root of the config file for services #110

Closed joel5vega closed 8 months ago

joel5vega commented 8 months ago

Pull Request description

How to test these changes

sugar build --verbose --config-file tests/containers/.services.sugar.yaml

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .
xmnlab commented 8 months ago

@joel5vega please rebase your branch on top of the upstream main.

now sugar.py was renamed to core.py

joel5vega commented 8 months ago

@xmnlab can you check if newest push solve the problem? image

xmnlab commented 8 months ago

Screenshot_20240119-231518_GitHub.jpg

It still has merge conflicts

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: