search

oslocyclotronlab / ompy

A python implementation of the Oslo method
https://ompy.readthedocs.io
GNU General Public License v3.0
7 stars 7 forks source link

Example data and response matrices are not installed #188

Open vetlewi opened 3 years ago

vetlewi commented 3 years ago

When installing using the command

pip install .

ie. not using the -e option ompy will be installed to the site-packages folder and not linked to the source folder. This will not copy the example_data and OCL_response_functions folders.

To fix this one should add a MANIFEST.in file with the following lines:

recursive-include example-data *
recursive-include OCL_response_functions *

I will fix this. Add it as an issue to remind myself :)

vetlewi commented 3 years ago

This turns out to be a little more complex than I initially thought. The OCL_response_functions and example-data directories might have to move into the ompy directory in order for them to be copied correctly. Will do some more research to determine what the best coarse of action is...

EDIT Okey... After a few google searches I've came to the conclusion that it might make more sense to refactor the examples package to download the example files directly from e.g. GitHub to a temporary folder. Similarly it might make sense to make a separate ompy-response package that will allow for easy loading of response matrices. Will close the PR #189 and keep this issue open.