search

oslocyclotronlab / ompy

A python implementation of the Oslo method
https://ompy.readthedocs.io
GNU General Public License v3.0
7 stars 7 forks source link

Fix for setup issue on non-x86 platforms #191

Closed vetlewi closed 1 year ago

vetlewi commented 3 years ago

The setup.py script used a x86 spesific flags,-mfpmath=sse, that would break compilation on other architectures. This flag is now disabled for architectures other than x86. Fixes issue #190.

Marked as draft awaiting test on an actual M1 computer.

vetlewi commented 3 years ago

This PR also adds "support" for GCC on macOS. This is not a normal setup and I'm considering removing it again. I cannot see any good reason to use GCC instead of clang...

vetlewi commented 3 years ago

This PR also adds "support" for GCC on macOS. This is not a normal setup and I'm considering removing it again. I cannot see any good reason to use GCC instead of clang...

I removed it. Added a note in the FAQ.

vetlewi commented 3 years ago

Can confirm that it compiles on laptops with M1 processors. Ready for merge.

vetlewi commented 2 years ago

Can confirm that it compiles on laptops with M1 processors. Ready for merge.

@ErlendLima @fzeiser

vetlewi commented 1 year ago

Being fixed in another PR, closing this.