osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.72k stars 1.03k forks source link

Quick action button - Fullscreen mode #16417

Open miramikes opened 1 year ago

miramikes commented 1 year ago

Hello, I believe fullscreen mode via "Quick action" button would be very useful from my experience. Quick action button would be visible even in fullscreen mode. Also I hope "Distance by tap" would be possible with Fullscreen mode in this case.

ManDay commented 1 year ago

@miramikes You can enter/leave fullscreen mode by tapping on the screen once - why would you need a Quick Action Button?

mikehgentry commented 1 year ago

That's only true if you have it set up like that - if you have distance by tap on instead, you can't.

ManDay commented 1 year ago

I didn't know that. As by https://github.com/osmandapp/OsmAnd/issues/16971 I think that Fullscreen precludes interaction primarily, therefore I don't think that showing Quickaction-Buttons is a good choice, at least for leaving Fullscreen.

Would double-tap to enter/leave fullscreen be possible or is that already taken?

mikehgentry commented 1 year ago

Double tap is zoom

ManDay commented 1 year ago

Ah yes, it's a bit unfair though, there are four methods to zoom (Pinch, Button, Hard-Button, Double-Tap) and Distance-Tap and Fullscreen fight for what's left :grin:

ManDay commented 1 year ago

PS: I was objecting to the FAB/QAB in Fullscreen because I think unless it's made configurable, it just raises the question which other buttons do (or not) "deserve" to populate Fullscreen, which seems kind of arbitrary and can't be solved in a satisfying way.

mikehgentry commented 1 year ago

Well, the plan is to allow quick actions to be put on different buttons.

The obvious answer would be for the quick action (or group of quick actions) that exits fullscreen to always be visible (at least unless you have it set to exit fullscreen by tapping)

ManDay commented 1 year ago

Can you be more specific? Are you referring to

Android / iOS: introduce a more powerful concept of Quick actions, so users can configure more than 1 quickly accessible button on the map.

Let me put it this way: Personally, I don't want any buttons to be visible in Fullscreen mode, as that would defeat the latter's purpose.

I could imagine a solution which might integrate easily into the existing, though: Configuring a Fullscreen Profile. That way, the general rule about what or what not to display in Fullscreen could be

Display all configurablee display in elements (widgets, buttons, etc.), and hide all non-configurable ones (zoom buttons, profile button, etc.)

The advantage would be complete generic flexibility, the obvious downside would be a fair amount of configuration overhead.

What do you think?

mikehgentry commented 1 year ago

That's rather off topic for this issue, but seems like it wouldn't work for me - I have lots of profiles (like, 4 for cycling alone). Some of them are used full screen. Duplicating them would be a pretty big overhead. You'd have to have the profile selection button still visible, presumably? So it's hard to see what this solves.

ManDay commented 1 year ago

I was just trying to reconcile my wish to hide all buttons in Fullscreen with your wish to have them. But it's not practical, I agree. I think the only solution which would make everyone happy is thus every QAB being configurable (visible in Fullscreen yes/no) individually?

Velomeloman commented 2 months ago

Also I hope \"Distance by tap\" would be possible with Fullscreen mode in this case.

Quote for reference