Favorites corruption when colon in favorite category name

opk12 commented 5 months ago

Description

I am seeing weird things with favorites when I make a category with the colon in the category name.

Steps to reproduce

1:

I had a category with the colon in the name.
I upgraded from 4.5. to 4.6..
The category was auto-deleted without notice.
I restored from backups, closed and reopened the app.
The category was OK.
I made a new favorite in that category.
I closed and reopened the app.
The category was auto-deleted again.

To check that the cat's name is at fault (not the favorites themselves): I restored from backup again and renamed the cat. Now the cat is OK and I can add favorites without losing the cat.

2:

Make a favorite Favorite a under a new category Test: a
Close and reopen the app.
The new category is auto-deleted without notice.
An unrelated favorite at 35 km was duplicated into a new favorite that has
- the same coordinates
- the app's default builtin category
- only the first ~110 characters of the favorite name

Actual result

see above

Expected result

see above

Your Environment (required)

OsmAnd Version: 4.6 from F-droid
Android/iOS version: Android 7.1
Device model: Samsung

There is no crash and apparently nothing relevant in the logcat.

yuriiurshuliak commented 5 months ago

The bug has been reproduced. To reproduce this issue create a folder named "Test:" for favorites, add your favorite to this folder, ensure both the folder and favorite are successfully created, then close the app entirely and open the app again. Next, navigate to My Places -> Favorites and try to find the "Test:" folder with your favorite. As a result, you will not be able to find this folder and your favorite.

OsmAnd~ 4.7.0#2031m, released: 2024-04-10

opk12 commented 5 months ago

Note that more general corruption can happen besides losing entries. As said, the favorite was duplicated with a truncated name.

osmandapp / OsmAnd