search

osmfoundation / welcome-mat

This is the code for the OpenStreetMap Welcome Mat website
https://welcome.openstreetmap.org/
14 stars 13 forks source link

accessiblity improvements #20

Closed russbiggs closed 5 years ago

russbiggs commented 5 years ago

In response to issue #19. Updated some page elements to improve overall accessibility. Most notably and title attributes on other elements. Some other issues still persist such as non-unique element ids and color contrast. These changes update the lighthouse report to 70-80 range for all pages: https://googlechrome.github.io/lighthouse/viewer/?gist=d8b110b27f2045c7081f640c1c330f47

mikelmaron commented 5 years ago

@russbiggs thank you for these improvements. I've made recommendations for alt text which is a little more descriptive and particular to OSM. Do you like these changes? Can you add them to the PR?

russbiggs commented 5 years ago

@mikelmaron I tried to make reasonable alt labels but I figured you might have suggestions for more descriptive titles. All look good to me. I'll update the PR.

russbiggs commented 5 years ago

@mikelmaron I've updated all the descriptions based on your recommendations. Let me know if you need any other changes before merging.

mikelmaron commented 5 years ago

thank you @russbiggs