search

osmfoundation / welcome-mat

This is the code for the OpenStreetMap Welcome Mat website
https://welcome.openstreetmap.org/
14 stars 13 forks source link

ODbL and some extra details into history #37

Closed drolbr closed 4 years ago

drolbr commented 5 years ago

The history related part of the pull request #36

matkoniecz commented 5 years ago

embarqued -> embarked?

Or maybe use some simpler word, like started?

Firefishy commented 4 years ago

@drolbr Happy with @stephankn comments about? Alternatively happy to review so we can get this merged.

mikelmaron commented 4 years ago

@Firefishy thanks for pinging here. Please hold, want to do some copy edits before merging

drolbr commented 4 years ago

Yes, I'm very happy with the changes. One side note: "On important step" should be "One important step".

mikelmaron commented 4 years ago

Had a chance to review and taking points from @stephankn, we should not duplicate content in other sections. For history, I picked out the formation of OSMF and switchover to ODbL as two significant additions here. I also think we can link to the OSM history page on the wiki.

@drolbr what do you think about updating the PR to this addition? Or if ok with you, I can go ahead and do that myself. Let me know what you prefer.

In 2006, the OpenStreetMap Foundation was established to encourage the growth, development and distribution of free geospatial data and provide geospatial data for anybody to use and share. In 2012, OpenStreetMap switched to licensing data under the Open Database License.

Read more about the history of OpenStreetMap on the OSM Wiki

drolbr commented 4 years ago

Thank you for the feedback. To get things done, I have removed the references to local chapters and the changeset discussions.

I prefer not to link to the wiki history page: it currently focuses mostly on the SotM conferences (including one that has not taken place), not the project as a whole. It may make sense to spark a discussion on that page there to get it to a more comprehensive state.

mikelmaron commented 4 years ago

@drolbr understood about not linking there. Can we use this phrasing below? I've tried to get the same essential information, but copyedited for clairty.

In 2006, the OpenStreetMap Foundation was established to encourage the growth, development and distribution of free geospatial data and provide geospatial data for anybody to use and share. In 2012, OpenStreetMap switched to licensing data under the Open Database License.

drolbr commented 4 years ago

Yes, I'm happy with the rephrasing. Could you check that in by yourself, please? I will then close this pull request as done.

mikelmaron commented 4 years ago

closed through update here https://github.com/osmfoundation/welcome-mat/commit/757704d4c9b72ead048d76f1ecfc78b9d9c7b53e