osmfoundation / welcome-mat

This is the code for the OpenStreetMap Welcome Mat website
https://welcome.openstreetmap.org/
14 stars 13 forks source link

General design issues #4

Closed imagico closed 6 years ago

imagico commented 6 years ago

In brief a few observations on the general presentation of this:

Addition:

mikelmaron commented 6 years ago

Thanks @imagico

How to give back might be a more suitable heading.

Makes sense

Most text seems to be shown two times - both the headings on the starting page and the content on the individual pages.

The headings are editable -- the description field in the yaml section of the post.

On some individual pages, the table of contents has a bug where it replicates all the content. Noted here

Some javascript prevents me from scrolling to the bottom on the individual pages.

I can't replicate this problem. What browser are you using? Do you see any error message in the developers console?

There is css sourced from Mapbox infrastructure - which is, even if Mapbox does not mind, not a good idea to use on OSMF pages. Should use our own corporate design and not that of Mapbox.

We can keep a local copy of the CSS https://github.com/osmfoundation/welcome-mat/issues/6.

It's not a corporate design, but a neutral starting point for the stylesheets. The style of the site itself -- colors, images, etc., are from OSM generally. We can further adapt the style to make it more distinct and in line with osm.org itself.

Uses javascript from googletagmanager.com which it probably should not.

Yup https://github.com/osmfoundation/welcome-mat/issues/7

imagico commented 6 years ago

I can't replicate this problem. What browser are you using? Do you see any error message in the developers console?

No error messages and it depends on the browser window configuration if this happens or not. Observed both with Chrome and Firefox.

I would suggest to simply remove any fancy javascript scrolling logic.

It's not a corporate design, but a neutral starting point for the stylesheets. The style of the site itself -- colors, images, etc., are from OSM generally. We can further adapt the style to make it more distinct and in line with osm.org itself.

Well the similarity in certain styling aspects with Mapbox pages is unmistakable. As said - it should be in line with the rest of the OpenStreetMap website.

mikelmaron commented 6 years ago

Well the similarity in certain styling aspects with Mapbox pages is unmistakable. As said - it should be in line with the rest of the OpenStreetMap website.

The best way forward is to adjust from what we have here. I don't think it would take much effort to make it in line with OSM. But we'd need to be specific about what to change.

tyrasd commented 6 years ago

Some javascript prevents me from scrolling to the bottom on the individual pages.

I saw this as well under a few conditions (as you can see here: osmf-welcome-mat-scrolling-bug.zip). I think it's caused by the overflowing "toc" sidebar (containing wrong and too much content), which should be fixed with #9

mikelmaron commented 6 years ago

Just made some updates which should close out all the issues here. @imagico please re-open if I missed something.