osmlab / atlas-checks

OSM data integrity checks with Atlas
BSD 3-Clause "New" or "Revised" License
57 stars 82 forks source link

MapRouletteUploadCommand Challenge Country Name Parameter #655

Closed Bentleysb closed 2 years ago

Bentleysb commented 2 years ago

Description:

This adds a new optional parameter to the MapRouletteUploadCommand to select whether to use the ISO code or country display name in uploaded challenge titles. Currently challenge titles are created with the pattern "Country Display Name - Check Name". When this new parameter is true, which it is by default, this same pattern will be used. When the parameter is false the pattern will be "ISO - Check Name".

Additionally this adds some missing docs, and bumps the atlas version.

Potential Impact:

This should be fully backwards compatible.

Unit Test Approach:

Added a unit test for when the param is false.

Test Results:

Ran three test runs with the param true, false, and not given.

True: Screen Shot 2022-02-11 at 2 45 38 PM

False: Screen Shot 2022-02-11 at 2 45 27 PM

Default: Screen Shot 2022-02-11 at 2 45 21 PM

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication