search

osmlab / atlas-checks

OSM data integrity checks with Atlas
BSD 3-Clause "New" or "Revised" License
57 stars 82 forks source link

MapRouletteCommand Optional Proxy Parameter #657

Closed Bentleysb closed 2 years ago

Bentleysb commented 2 years ago

Description:

This adds a new optional -proxy parameter to the MapRouletteCommand. The proxy is defined in the format scheme://host:port, and is fed through to the underlying apache HttpClients. A number of new constructors are created to achieve this, but everything is backwards compatible.

Potential Impact:

None, everything is backwards compatible.

Unit Test Approach:

Updated the test connection class, and added a unit test to ensure the proxy param is parsed correctly.

Test Results:

Tested running with a proxy from behind a restricted network. Project, challenges, and tasks were created successfully:

Screen Shot 2022-02-18 at 9 51 35 AM

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

58.8% 58.8% Coverage
0.0% 0.0% Duplication