search

osmlab / atlas-checks

OSM data integrity checks with Atlas
BSD 3-Clause "New" or "Revised" License
57 stars 82 forks source link

InvalidGeometryCheckTest add roller coaster logic #669

Closed vladlemberg closed 2 years ago

vladlemberg commented 2 years ago

Description:

please refer to: https://github.com/osmlab/atlas-checks/issues/645 implemented in check Configuration. attraction->!roller_coaster&roller_coaster->!

Potential Impact:

OSM objects with tags "roller_coaster=*" and "attraction=roller_coaster" will be filtered out from check.

Unit Test Approach:

Created unit test for "roller_coaster=*" and "attraction=roller_coaster" cases.

Test Results:

passed.

vladlemberg commented 2 years ago

@Bentleysb, the gt-shapefile-20.2.pom is no longer available under the path: Could not get resource 'http://repo.osgeo.org/repository/release/org/geotools/gt-shapefile/20.2/gt-shapefile-20.2.pom'.

I can redirect to dependency to here: https://mvnrepository.com/artifact/org.geotools/gt-shapefile/20.2

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Bentleysb commented 2 years ago

gt-shapefile is available there. The github ci has just had some trouble retrieving it lately. A rerun of the ci build usually fixes it, as it has here.