[New Atlas Check] LoneBuildingNodeCheck and EnclosedBuildingNodeCheck

[vladlemberg]

Description:

LoneBuildingNodeCheck: The purpose of this check is to convert a Node with building tag into Building Footprint polygon (enclosed Way or Relation). EnclosedBuildingNodeCheck:The purpose of this check is to remove building tag from the Node that is fully geometrically enclosed into Building Area. |

For more Check information with used cases and OSM wiki reference please refer to: https://github.com/osmlab/atlas-checks/issues/682 https://github.com/osmlab/atlas-checks/issues/681

Potential Impact:

EnclosedBuildingNodeCheck: Better building tag mapping according to OSM common practice. LoneBuildingNodeCheck: Increasing building footprint coverage.

Unit Test Approach:

Note: QA validation release "daylight_2022-06-18". Vast majority of FP cases already been fixed in OSM by community.

Test Results:

LoneBuildingNodeCheck	ISO	Total Flags	Sampled	Sampling %	TP	FP	False Positive Rate
USA	37183	400	1%	384	16	4%
NLD	411	150	36%	139	11	7.3%
NZL	250	450	55%	54	11	12%
SAU	1101	500	45%	455	45	9%
URU	89	89	100%	89	0	0%

EnclosedBuildingNodeCheck	ISO	Total Flags	Sampled	Sampling %	TP	FP	False Positive Rate
USA	13963	350	2,5%	13963	0	0%
NLD	179	179	100%	173	6	3%
NZL	157	157	100%	157	0	0%
SAU	30	30	100%	18	12	40%
URU	4	4	100%	3	1	25%

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.8% Coverage
0.0% Duplication