osmlab / checkin-checker

A simple application that notifies you when a Foursquare checkin venue doesn't exist in OSM.
https://checkin-checker.dev.openstreetmap.us/
MIT License
19 stars 3 forks source link

City Name in Venue Name Matches Administrative Boundary #12

Closed talllguy closed 8 years ago

talllguy commented 8 years ago

I checked into a service shop with its city name in the venue name (which is against Foursquare guidelines, but that's another issue). Checkin-checker dutifully matched my checkin to the town boundary.

2016-05-02 11_52_47-inbox elliott plack gmail com

iandees commented 8 years ago

Hm, two issues I see here:

  1. The distance between Glen Burnie and Service Collision Repair Glen Burnie should be way bigger than it is. I wonder if I'm using the wrong fuzzy match algorithm or have parameters flipped around...
  2. We should probably ignore administrative boundary matches altogether.
iandees commented 8 years ago

I think I solved this in #13 by switching to a different matching algorithm. Let me know if you run into it again.