search

osmlab / checkin-checker

A simple application that notifies you when a Foursquare checkin venue doesn't exist in OSM.
https://checkin-checker.dev.openstreetmap.us/
MIT License
19 stars 3 forks source link

Checkin "is on" OSM links broken #15

Open chadlawlis opened 8 years ago

chadlawlis commented 8 years ago

While the direct links to the checkin areas in OSM seem to be functional for checkins that are not on OSM, the direct links for those that are on OSM seem to be "broken".

For example, today I checked into a deli "Aux Délices" in Darien, CT in Swarm which was not yet in OSM. Checkin Checker generated the following direct link: https://www.openstreetmap.org/edit?zoom=19&lat=41.078342&lon=-73.465999. This is the correct area, and I added the deli to OSM.

Yesterday, I checked into "Fort Adams State Park" in Newport, RI in Swarm which was already in OSM. Checkin Checker generated the following direct link: https://www.openstreetmap.org/edit?node=357259588. However, clicking this link took me to the same area as "Aux Délices" (from above) with the resulting link: https://www.openstreetmap.org/edit?node=357259588#map=19/41.07834/-73.46600.

This seems to be happening consistently for me. I have cleared my cache and done a hard refresh with no success. Simply put, the direct link to places already in OSM ultimately navigate to the previous area from a checkin not in OSM.

Any idea what's going on here @iandees? Let me know if this needs further clarification/examples.

iandees commented 8 years ago

Huh, interesting. I guess a fix here would be to include the lat/lon in the edit link. I was expecting OSM to automatically do that based on the node position.

chadlawlis commented 8 years ago

That could work. Another fix would be to reformat the link to the node itself, e.g. https://www.openstreetmap.org/node/357259588 (using the same node for "Fort Adams State Park" as above). The user can still choose to edit from here, which generates the following link if iD is selected: https://www.openstreetmap.org/edit?editor=id&node=357259588#map=19/41.47816/-71.33557.

Adding the lat/lon probably makes the most sense though (https://www.openstreetmap.org/edit?node=357259588#map=19/41.47816/-71.33557), as you suggested, keeping it consistent with the links from checkins that are already in OSM.