osmosis-labs / osmosis-rust

Rust libraries for osmosis
Apache License 2.0
59 stars 52 forks source link

Please document Bank.MsgSend.from_address possible values #81

Closed dzmitry-lahoda closed 1 year ago

dzmitry-lahoda commented 1 year ago

is that value can be anything when called from permission less CW contract?

https://github.com/osmosis-labs/osmosis-rust/blob/b78e29b7d6b7e21d8024f13a24820cc040646b6f/packages/osmosis-std/src/types/cosmos/bank/v1beta1.rs#L707

or some checks are done?

if behavior is different for permissions and permissioned contracts, how to check if my contract is one of two?

dzmitry-lahoda commented 1 year ago

i found only send token approval for now. any other authorization kind? full proxy to do any spending any time?

iboss-ptk commented 1 year ago

I'm not sure if I understand what you mean but how MsgSend works is that it works as it should with bank module. And from_address should be contract address since it's the sender.

dzmitry-lahoda commented 1 year ago

question is what if cw contract will set here non contract address?

iboss-ptk commented 1 year ago

could you elaborate? @dzmitry-lahoda