Closed triccs closed 11 months ago
@iboss-ptk is there anyway we could get PR #89 & PR #87 merged & released before Oct. 2nd? I'm looking to get the incentives working for a potential launch at that time.
@iboss-ptk is there anyway we could get PR https://github.com/osmosis-labs/osmosis-rust/pull/89 & PR https://github.com/osmosis-labs/osmosis-rust/pull/87 merged & released before Oct. 2nd? I'm looking to get the incentives working for a potential launch at that time.
That's possible @triccs. For this PR it looks a bit tricky, fixing generated code directly will be overwritten but to automate this, it seems that it's very specific to this field of this msg but for not all u64
.
One way I can think of is to modify this transformer to also take src: &Path, descriptor: &FileDescriptorSet
, with that we can use get_type_url
in the transformer and allow us to specify optional int field (hence empty string) like so
transformers::allow_serde_int_as_str(src, s, descriptor,
// optional int fields
vec![
("/osmosis.incentives.MsgCreateGauge", vec!["pool_id"])
]
)
I can work on this if you want, can get it up before Oct 2nd. Gotta clear some other work first this week :)
@iboss-ptk is there anyway we could get PR #89 & PR #87 merged & released before Oct. 2nd? I'm looking to get the incentives working for a potential launch at that time.
That's possible @triccs. For this PR it looks a bit tricky, fixing generated code directly will be overwritten but to automate this, it seems that it's very specific to this field of this msg but for not all
u64
.One way I can think of is to modify this transformer to also take
src: &Path, descriptor: &FileDescriptorSet
, with that we can useget_type_url
in the transformer and allow us to specify optional int field (hence empty string) like sotransformers::allow_serde_int_as_str(src, s, descriptor, // optional int fields vec![ ("/osmosis.incentives.MsgCreateGauge", vec!["pool_id"]) ] )
I can work on this if you want, can get it up before Oct 2nd. Gotta clear some other work first this week :)
I appreciate it. I definitely thought this would be simple, so thanks for adding it to your list.
Change pool_id to an Option so you can create gauges ByDuration