search

osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
892 stars 593 forks source link

chore: bump sdk and cometbft #8743

Closed PaddyMc closed 1 month ago

PaddyMc commented 1 month ago

What is the purpose of the change

Bumping cometbft and cosmos sdk to the lastest versions:

comet => https://github.com/osmosis-labs/cometbft/releases/tag/v0.38.12-v26-osmo-2 cosmossdk => https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.10-v26-osmo-2

github-actions[bot] commented 1 month ago

Important Notice

This PR modifies an in-repo Go module. It is one of:

The dependent Go modules, especially the root one, will have to be updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request introduces multiple updates to the Osmosis project, including new features, bug fixes, and breaking changes. Notable enhancements involve additional queries in the x/gauges module, improved command execution handling, and ledger signing capabilities in the smart account module. The updates also include significant state-breaking changes due to SDK and CometBFT version upgrades, along with various fixes related to delegation iterations and error handling.

Changes

File Path Change Summary
CHANGELOG.md Updated to reflect multiple enhancements, bug fixes, and breaking changes across various modules.
x/gauges Method added: Additional queries introduced.
command-execution Method signature updated to handle multiple temp directories on command executions.
delegation Method signature updated to continue iteration on delegations instead of throwing an error.

Possibly related PRs

Suggested labels

V:state/breaking

Suggested reviewers

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
czarcas7ic commented 1 month ago

Shouldn't we be updating https://github.com/osmosis-labs/cometbft/tree/osmo/v0.38.x instead of creating an entirely new branch?

czarcas7ic commented 1 month ago

https://github.com/osmosis-labs/cometbft/blob/osmo/v0.38.12/CHANGELOG.md#osmosis-specific-changes

I am a bit confused on this, everything below 1c07c7c is newly added, there is no way all of these changes are Osmosis specific changes that are not upstreamed right?

For reference, this is what it looked like in osmo/v0.38.x https://github.com/osmosis-labs/cometbft/blob/osmo/v0.38.x/CHANGELOG.md#osmosis-specific-info

czarcas7ic commented 1 month ago

It seems we are using an osmo/v0.38.12 branch for our comet fork, but are still using the osmo/v0.50.x branch for the sdk. Can we keep the same standard between these repos?

EDIT: Actually, I take this back, it seems like osmo/v0.50.x is behind in compared to the tag that you made, so I am a bit confused what the base is that we are using now for the sdk.

czarcas7ic commented 1 month ago

Reading the changelog in the sdk fork that you tagged:

https://github.com/osmosis-labs/cosmos-sdk/blob/v0.50.10-v26-osmo-1/CHANGELOG.md#v050x-v26-osmo-1

This commit is from 5 months ago, so I assume this was not updated to match where we forked off the sdk.

PaddyMc commented 1 month ago

Shouldn't we be updating https://github.com/osmosis-labs/cometbft/tree/osmo/v0.38.x instead of creating an entirely new branch?

This wasn't as easy as expected, I think creating a new branch is actually the best way to do this.

e.g => https://github.com/osmosis-labs/cometbft/blob/osmo/v0.38.12/CHANGELOG.md

This is a branch for cometbft now, I think you're right tho, I'll create a branch for both v26 and v27 with the prefix for each, to make it easier to know which is which.

&&

https://github.com/osmosis-labs/cosmos-sdk/tree/osmo-v27/0.50.10 => this is the commit for the cosmos-sdk

PaddyMc commented 1 month ago

Reading the changelog in the sdk fork that you tagged:

https://github.com/osmosis-labs/cosmos-sdk/blob/v0.50.10-v26-osmo-1/CHANGELOG.md#v050x-v26-osmo-1

This commit is from 5 months ago, so I assume this was not updated to match where we forked off the sdk.

Ah sorry I forgot to update the changelog there will do that now :sweat:

Commits are recent: https://github.com/osmosis-labs/cosmos-sdk/commits/v0.50.10-v26-osmo-1/

PaddyMc commented 1 month ago

So updated the branches and changelogs of each! Lmk what you think, I think this is the pattern we should follow going forward

e.g https://github.com/osmosis-labs/cosmos-sdk/tree/osmo-v26/0.50.10

&&

https://github.com/osmosis-labs/cometbft/tree/osmo-v26/0.38.12