search

osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Color Selection for Sharing Icons #17

Open katyfb13 opened 10 years ago

katyfb13 commented 10 years ago

Social Sharing > Allowing selection of a color for all icons would be a great enhancement so users could show a single color without needing custom CSS. ( Like http://www.briangardner.com/downton-abbey/ )

bgardner commented 10 years ago

+1 on this. Just adding an option to override social media brand colors with a color dropper hexcode one.

NicktheGeek commented 10 years ago

Just to be clear, this would be a single color that would override all of the colors at once, not something we would make available to change each social button to suit a given color scheme right?

bgardner commented 10 years ago

Right, like my site, I have all icons set to use background color #000 on icons across the board. This is just for personal brand. So options would either be a) use social colors out of the box b) new option to set one color for all icons or c) customize your own styles ala style.css.

bgardner commented 10 years ago

Just wanted to ping you @NicktheGeek on this again, as I can see this easily being the most requested item. Yes, we can tell people how to do this via CSS, but for Rainmaker folks, a simple color picker override would be a brilliant addition to the plugin.

NicktheGeek commented 10 years ago

I'm a bit torn on this. I'd like to see if maybe Norcross would be interested in adding an option to DPP if Genesis Simple Share is active. For RM I feel like that would be better than having design options in more than one place. Otherwise maybe I could hook into DPP so the options would be there.

omiq commented 10 years ago

Agreed, or provide hooks so we can add it. I'd like to centralise as much as we can versus having similar features spread out.

omiq commented 9 years ago

Right now DPP is off the table so what is the best non-DPP solution?

bgardner commented 9 years ago

I honestly think a checkbox for "universal color" and a color picker right where the Share options are is the best user experience. JMO.

dreamwhisper commented 9 years ago

I honestly think a checkbox for "universal color" and a color picker right where the Share options are is the best user experience

I'm ok with this approach since it centralizes all the settings for social sharing.

Along with this, we need a filter that can be used for default values set in the theme.

NicktheGeek commented 9 years ago

Right now DPP is off the table so what is the best non-DPP solution?

I'd like to use the Customizer if we are going to add any color options just for this plugin. We are moving other color settings to the customizer for some of the newer themes so it makes more sense to me to have colors and styles handled in a central place.

bgardner commented 9 years ago

I'm in support of any method that allows us to universally change icon colors to one color. :-)

dreamwhisper commented 9 years ago

I'd like to use the Customizer if we are going to add any color options just for this plugin.

That works for me too :)

katyfb13 commented 9 years ago

Yall want to get this in to Rainmaker 2.2? And who is the lucky dev?

NicktheGeek commented 9 years ago

@katyfb13 I think we can shoot for 2.2 and I can dev this since it's in GSS. Do you want to make a tracking issue in the RM repo though?

katyfb13 commented 9 years ago

Do you want to make a tracking issue in the RM repo though?

yes will do! Thanks.

katyfb13 commented 9 years ago

actually, it's already there https://github.com/copyblogger/synthesis-platform/issues/1142

dreamwhisper commented 8 years ago

we need a filter that can be used for default values set in the theme

Also, border radius would be helpful.