osparcomm / HARSAT

Harmonized Regional Seas Assessment Tool
https://osparcomm.github.io/HARSAT/
Other
0 stars 5 forks source link

Issue 470 update treatment of WHO TEFs #474

Closed RobFryer closed 3 months ago

RobFryer commented 4 months ago

470

WHO TEFs

Updates and corrects info_TEF. There are now four versions of the WHO TEFs for dioxins, furans and planar PCBs:

DFP_2005 and DFP_2022 use determinand OCDF (the correct code) rather than CDFO (which is a grouped determinand code)

DFP_HOLAS3 and DFP_CEMP are mainly included for backwards compatibility.

The documentation for info_TEQ has been greatly improved.

Deprecating determinand.link.TEQDFP

This function will be deprecated at the next release 1.0.2 and then removed at the following release. It has been superseeded by determinand.link.sum. Code has been added to warn the user of this. This has required updating of the DESCRIPTION file to include the packages lifecycle and rlang. A couple of minor inconsistencies were resolved along the way.

The code has been tested using the OSPAR and HELCOM examples and the vignettes have been updated accordingly

annelaerkes commented 3 months ago

Hi @RobFryer, should I merge this pull request? I realised it has just been sitting there all summer