search

osrf / mbari_wec_gz

Simulation of wave energy harvesting buoy
Apache License 2.0
18 stars 2 forks source link

Temporarily add on_exit_shutdown to ros_gz humble branch until backport #166

Closed andermi closed 12 months ago

andermi commented 12 months ago

The ros2 branch on ros_gz has moved passed us so we need to be on the humble branch. I just noticed that this PR hasn't been backported to humble and notified @mjcarroll who is working on it now. The issue is that the batch script won't run more than one sim because it doesn't shutdown the current launch when gz sim exists.

In the meantime (until the backport): in the ros_gz clone:

$ git checkout ros2
$ git pull
$ git checkout humble
$ git pull
$ git cherry-pick 63e85a952668b824d266740606a245c2a1db4d0c

and then colcon build the workspace again

mjcarroll commented 12 months ago

Backports are in, I'll try to get a release out ASAP

andermi commented 12 months ago

thanks a ton for the quick turnaround!