search

osrf / robocup3ds

Gazebo support for the RoboCup 3D simulation league.
11 stars 2 forks source link

Playmode strings are incompatible with SimSpark #18

Closed osrf-migration closed 8 years ago

osrf-migration commented 8 years ago

Original report (archived issue) by Jens Fischer (Bitbucket: Gama11).

It seems like the plugin consistently uses PascalCase for playmode names, wheareas in SimSpark, there's a bit of everything (for example KickOffLeft in gazebo vs KickOff_Left in SimSpark). Has this been done deliberately?

While the consistent naming is nice, this means that every team will have to adjust their parser to be compatible with both.

osrf-migration commented 8 years ago

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).

Merged in Gama11/robocup3ds/issue_18 (pull request #51)

Use the same playmode names as SimSpark, fixes #18

→ \<\<cset a0163762449e537cef855e91daf3fcc2f310502d>>

osrf-migration commented 8 years ago

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).

Use the same playmode names as SimSpark, fixes #18

→ \<\<cset b784447e22a9f8ffd719bd773e8ef2c1ab1d6731>>

osrf-migration commented 8 years ago

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).

Merged in Gama11/robocup3ds/issue_18 (pull request #51)

Use the same playmode names as SimSpark, fixes #18

→ \<\<cset a0163762449e537cef855e91daf3fcc2f310502d>>