search

ossn / ossn-frontend

The homepage of Mozilla's Open Source Student Network
https://ossn.club
MIT License
4 stars 11 forks source link

Club page emails are hardcoded to `mailto:` links #285

Open ct-martin opened 5 years ago

ct-martin commented 5 years ago

Club emails are hard-coded to mailto: links regardless whether they are links or emails, e.g. RITlug's mailing list gets converted to mailto:https://groups.google.com/forum/#!forum/ritlug-announce

See: https://github.com/ossn/ossn-frontend/blob/fa4cb2f46bf0467df1752a16f83d89f740496ebc/src/components/components/club-info/club-info.js#L120-L132

shakti97 commented 5 years ago

Can you explain a little bit more? Are trying to say that the email prop will have to types of content either email or links For email we need mailto but for links we don't is this you want to say?

ct-martin commented 5 years ago

@shakti97 RITlug uses a mailing list rather than a set email, which there's a link to and that link should not get cast to mailto:. If you look at the example in the OP, the RITlug mailing list has two protocols given. Granted, I wrote this issue 6 months ago so I'm doing this based on what I see in the OP.

ct-martin commented 5 years ago

(so I guess this is a feature request to support links as a data type in addition to email addresses?)