ostark / upper

Integrates Edge Caches like Fastly, KeyCDN, Cloudflare and Varnish with Craft.
MIT License
102 stars 22 forks source link

Newer implementations of live preview do not bypass the cache #50

Open timkelty opened 3 years ago

timkelty commented 3 years ago

I think we just need to use getIsPreview instead: https://github.com/craftcms/cms/blob/develop/src/web/Request.php#L690

ostark commented 3 years ago

Go ahead, @timkelty, bump the Craft version to ^3.2.1 and use Request::getIsPreview().

taylordaughtry commented 2 years ago

@timkelty @ostark Hi! Just bumping this thread—was this solved in some other fashion? Happy to PR this, if it hasn't been tidied up just yet.

timkelty commented 2 years ago

@taylordaughtry Looks like it hasn't! Send a PR over and I'll merge with a smile.