search

ostinelli / apnotic

A Ruby APNs HTTP/2 gem able to provide instant feedback.
MIT License
477 stars 95 forks source link

Ruby 3.0 support #114

Closed clarkedb closed 2 years ago

clarkedb commented 2 years ago

Is there a plan to support Ruby 3.0.x in a future release of apnotic?

collimarco commented 2 years ago

We are using it on Ruby 3.0.3.

Have you experienced any problems on that version / newer versions?

clarkedb commented 2 years ago

We are using it on Ruby 3.0.3.

Have you experienced any problems on that version / newer versions?

No, I just had not been able to verify from the documentation that it would support Ruby 3.x, and my development environment isn't set up to be able to run all of the apnotic code due to issues with actually triggering a pn from that environment. I'm working on getting that working as well though.

I will mark this as closed and submit an issue if I run into an actual problem running it.

collimarco commented 2 years ago

In any case someone should add the new ruby version to .travis.yml ...

clarkedb commented 2 years ago

@collimarco I've submitted a PR to add 3.0 and 3.1. Locally, the tests all pass for both 3.0 and 3.1.