search

osuosl / dougfir-pelican-theme

Pelican theme based off of the OSU Dougfir Drupal theme
Apache License 2.0
2 stars 2 forks source link

Leian/sync scss #40

Closed leian7 closed 8 years ago

leian7 commented 8 years ago

Addresses #37 . The compiled form of main.scss now matches main.css; no variables have been made yet. Any suggestions as to what to variable-ize besides title color?

To test this PR:

  1. In static/css/, sass main.scss temp.css to generate the css from main.scss.
  2. diff temp.css main.css to confirm that they now match

@subnomo @athai @Kennric @alxngyn

subnomo commented 8 years ago

Looks good, but maybe you should add the main.css.map since the main.css points to it.

leian7 commented 8 years ago

@subnomo Thanks. It looks like source maps are generated automatically upon compile, and someone already put *.map in the .gitignore. Should we start tracking maps anyway?

subnomo commented 8 years ago

@leian7 Good question. I actually don't think we should be tracking generated files at all, we should remove main.css from the repo and add it to the .gitignore.

But then we'd have to make pelican generate the css, and I think that's out of scope for this PR. For now, I'll just give my +1.

athai commented 8 years ago

+1

subnomo commented 8 years ago

Good work, looks good :+1: