osuosl / dougfir-pelican-theme

Pelican theme based off of the OSU Dougfir Drupal theme
Apache License 2.0
2 stars 2 forks source link

odd even row coloring for powerdev #77

Closed knightsamar closed 7 years ago

knightsamar commented 7 years ago

Odd-even row coloring for tables on POWERDev page

Nicked from the styling on old drupal page at http://d7.osuosl.org/services/powerdev

Browser support: http://caniuse.com/#search=nth

Part of https://github.com/osuosl/osuosl-pelican/pull/135

ramereth commented 7 years ago

Is there any reason why this can't be the global way we tables? I'd wager that this style was global in the old theme and just wasn't ported over.

knightsamar commented 7 years ago

@Kennric do we want to make this a global style for tables ? Also do I need to modify the SCSS files too ? I haven't done SASS before so didn't even open the file :)

Kennric commented 7 years ago

@knightsamar It's probably worth making a global style and looking to make sure it doesn't pop up in unexpected places - like a table used for some layout somewhere that shouldn't be colored. If that looks good, yes, this should be a global style.