Closed tschuy closed 9 years ago
I'm going to build Debian 7 and 8 wheels tomorrow.
I've removed the wheel docs and put them on Wiki. That link will fail til https://github.com/osuosl/wiki/pull/20 is merged.
This is Ready for Review :copyright:
I recommend testing this by spinning up a raw VM on openstack, installing git, cloning GWM and switching branches to tschuy/wheels, and then running the GWM install script. (Don't do what I did and switch to develop. That will make things appear to work even if they shouldn't.)
Note for that! Centos 6 doesn't have python-virtualenv
in the default repositories. You'll need to install epel
first. Also, Debian 7 and 8 have ancient versions of python-virtualenv
, wow.
Though @Kennric @jordane I'd still love feedback on the installation process on non-Debian, non-Centos machines. Specifically:
https://github.com/osuosl/ganeti_webmgr/pull/83/files#diff-1d889b31bb06cb578abde8e2253d043aR230
I think I should get rid of this, and say "install the deps yourself". Thoughts?
This works pretty well on centos7 and debian8 for me. One confusion while stepping through the install steps was accidentally sourcing the virtualenv as a user, then trying to run manage commands with sudo - it might be worth clarifying that sudo commands don't inherit the virtualenv of the user.
As for non-debian, non-centos systems - I think it is reasonable to provide manual instructions and a list of dependencies for platforms we don't have the resources to test fancy install mechanisms for.
I've updated the docs on installing, and removed the auto-install of anything build related.
Looks pretty good to me. @jordane ?
+1 looks sane to me.
Adds docs about wheels, how they're used, how to build and deploy them.
Also updates the
setup.sh
to once again not install a compiler, unless you're on Ubuntu (the script only really supports Debian and Centos).Should I remove the ubuntu compiler installation as well, and just add comments in the installation docs about how to install on Ubuntu? It would literally consist of a line saying "install these compiler deps, and then run setup.sh script."
it's also worth noting that the script will happily fall back onto installing things from PyPi -- this is actually being used right now for Django, since Django 1.4 doesn't support being wheelified.
And bold for importance: I don't want this stuff on a non-https host. That makes pip angry and I have to add a flag to cancel the warning, and I really don't want to do that for things being installed across the web.
@Kennric @jordane Thoughts on the installation process, esp. on ubuntu, and on where to host the packages? And ideas for what to do with Django? I'm ok with leaving it as is.