Baileysingleton/sku crud

osuosl / iam

Invoicing and metrics project

Other

4 stars 0 forks source link

Baileysingleton/sku crud #272

Closed baileysingleton closed 7 years ago

baileysingleton commented 7 years ago

fixes issue #xx

Changes in this PR.

[X] Passing Spec tests
[X] Added Factory for testing
[X] Wrote routes for SKU
[X] Index, Edit and Create Views
[x] Show and Summary Views

Testing this PR.

Run Rake Spec or ./run-tests.sh
See that all written tests pass

Expected Output.

$ rake spec
[...]

@osuosl/devs

baileysingleton commented 7 years ago

I'm not exactly sure how the show and summary views for the crud need to be formatted. I was comparing them with the other views and they are all slightly different, so I didn't know which parts to include.

alxngyn commented 7 years ago

looks good. I ran into a caching issue when i tried to edit the SKU but that's not related to this PR.

baileysingleton commented 7 years ago

@hsolorza Updated with your requests!