WIP make sure we store booleans

osuosl / iam

Invoicing and metrics project

Other

4 stars 0 forks source link

WIP make sure we store booleans #276

Closed Kennric closed 7 years ago

Kennric commented 7 years ago

fixes issue #274

Changes in this PR.

[X] Store true or false instead of coercing "true" and "false" into boolean db field

Testing this PR.

docker-compose up test
run on staging

Expected Output.

Data collected should include active and inactive nodes with the correct boolean true or false, instead of all "true"

$ rake spec
[...]

@osuosl/dev

alxngyn commented 7 years ago

do we need to run a script to change existing data?

Kennric commented 7 years ago

@alxngyn no, I think existing data is correct - postgres seems to do the right thing, and will coerce "true" to a boolean true, and "false" to boolean false, but it's not clear what it does when you try to save a non-truthy/falsey string to it. This is just a little extra precaution.

hsolorza commented 7 years ago