Closed chrissy-dev closed 5 years ago
Very nice. I would love to see this merged.
Please update your pull request so that you try to merge to develop
branch.
And fix the conflict.
Thanks.
From what I can tell, you don't have an icon for .conf
files. The default icon in apache does not follow the theme of apaxy. Is this something we can add? See #111. I have an idea for an icon, but it's not what I would consider a quality icon.
@oupala Conflicts fixed, also fixed the Dockerfile adding support for {FOLDERNAME}
.
@jordanbancino .conf
icon has been added.
Any chance I can be added as contributor to the project so I can create branches within the repo?
Nice. I’ll close #111
Good news @chrisssycollins.
Is it possible for you to rebase your commits in order to follow conventional changelog convention for your commit messages? It allows to generate an automatic changelog file.
Please use angular convention.
Besides, I think it is best to not mix commits from different features in a same pull request (ie. new icons vs Dockerfile fix.
For sure I will add some contributor to the projet once pull requests and issues have been purged from pending ones.
Any thought about my last comment, @chrisssycollins?
Hi @chrisssycollins,
Your pull request has been opened for a long time now. It is mainly my fault and I'm sorry for that.
I had a look at your pull request and I find your icons very beautiful. I think it must have taken a lot of time for you to draw all of them. I'd be pleased to merge them.
Your pull request is however a huge pull request and most of its content is already existing of fixed (or not applicable any more) in the develop branch.
Would you mind update your pull request or create a new one only to update the icons? There might be some new icons to draw for you.
For all other points of your pull request, we can discuss it here.
Please let me know what you think about all that!
@oupala No problem, I'll create a pull request specifically for the icons.
Great!
I close this pull request then.
Dockerfile
I will open source the icons as a personal project at some point.
Regarding #101 I would be happy to keep the project alive.
I'd like to:
Also maybe:
Screenshot