Recreated icons for retina displays

oupala / apaxy

a simple, customisable theme for your apache directory listing

https://oupala.github.io/apaxy/

GNU General Public License v3.0

1.86k stars 256 forks source link

Recreated icons for retina displays #103

Closed chrissy-dev closed 5 years ago

chrissy-dev commented 6 years ago

Recreated all of the icons, added some more (also merged and removed some)
Added creation of all supported filetypes in the Dockerfile

I will open source the icons as a personal project at some point.

Regarding #101 I would be happy to keep the project alive.

I'd like to:

Use semantic versioning
Use releases
Have a static demo site hosted at GitHub pages
Refresh the styling slighting
Refactor CSS

Also maybe:

Create an open organisation (shared ownership)
Have themes/icon packs hosted within the organisation

Screenshot

screencapture-localhost-8080-1515174645693

ghost commented 6 years ago

Very nice. I would love to see this merged.

oupala commented 6 years ago

Please update your pull request so that you try to merge to develop branch.

And fix the conflict.

Thanks.

ghost commented 6 years ago

From what I can tell, you don't have an icon for .conf files. The default icon in apache does not follow the theme of apaxy. Is this something we can add? See #111. I have an idea for an icon, but it's not what I would consider a quality icon.

chrissy-dev commented 6 years ago

@oupala Conflicts fixed, also fixed the Dockerfile adding support for {FOLDERNAME}.

@jordanbancino .conf icon has been added.

Any chance I can be added as contributor to the project so I can create branches within the repo?

ghost commented 6 years ago

Nice. I’ll close #111

oupala commented 6 years ago

Good news @chrisssycollins.

Is it possible for you to rebase your commits in order to follow conventional changelog convention for your commit messages? It allows to generate an automatic changelog file.

Please use angular convention.

Besides, I think it is best to not mix commits from different features in a same pull request (ie. new icons vs Dockerfile fix.

For sure I will add some contributor to the projet once pull requests and issues have been purged from pending ones.

oupala commented 6 years ago

Any thought about my last comment, @chrisssycollins?

oupala commented 5 years ago

Hi @chrisssycollins,

Your pull request has been opened for a long time now. It is mainly my fault and I'm sorry for that.

I had a look at your pull request and I find your icons very beautiful. I think it must have taken a lot of time for you to draw all of them. I'd be pleased to merge them.

Your pull request is however a huge pull request and most of its content is already existing of fixed (or not applicable any more) in the develop branch.

Would you mind update your pull request or create a new one only to update the icons? There might be some new icons to draw for you.

For all other points of your pull request, we can discuss it here.

Please let me know what you think about all that!

chrissy-dev commented 5 years ago

@oupala No problem, I'll create a pull request specifically for the icons.

oupala commented 5 years ago

Great!

I close this pull request then.