Closed PeterDaveHello closed 6 years ago
This looks good.
Could you please follow conventional changelog convention for your commit messages? It allows to generate an automatic changelog file.
Please use angular convention.
Should be good now?
Commit message is good, but you're pull request is trying to merge into master
while the development branch is develop
.
So, maybe the default branch should be develop
not master
? Can we have contribution guide about these rules?
You're right, I just changed the default branch from master
to develop
.
Is it possible for you to change the destination branch of your pull request?
Done.
By the way, do you want to start a new contribution guide?
If I'm one of the collaborators in this project, yes, of course.
The origin files have some trailing space, trailing newline, indentation issues, AKA coding style issues, this pull request can help improve the readability and more important the maintainability of codes in this project.
I could help integrate some checking with continuous integration to help test future changes to prevent regression issues.