search

oupala / apaxy

a simple, customisable theme for your apache directory listing
https://oupala.github.io/apaxy/
GNU General Public License v3.0
1.86k stars 256 forks source link

inline javascript does not comply Content Security Policies #83

Closed oupala closed 6 years ago

oupala commented 7 years ago

apaxy homepage contains some inline javascript (see these lines).

Content Security Policy encourage to move inline javascript into a separate javascript file and not to use script-src 'unsafe-inline'.

apaxy should move inline javascript into a separate javascript file.

oupala commented 7 years ago

I created a pull request about that into #84

oupala commented 7 years ago

By the way, I wonder what it this javascript useful for?

Everything seems to work even without this piece of javascript. Am I missing a specific feature?

oupala commented 7 years ago

Are you willing to merge this request or not?

Is there a problem with my code? Should I improve it in a specific way?

rivermont commented 6 years ago

@oupala Can this be closed now that the pull was merged?

oupala commented 6 years ago

You're right!