search

oupala / apaxy

a simple, customisable theme for your apache directory listing
https://oupala.github.io/apaxy/
GNU General Public License v3.0
1.86k stars 256 forks source link

Ebook #85

Closed pollier closed 6 years ago

oupala commented 6 years ago

Could you please fix conflicts of this pull reques so that I can merge it?

oupala commented 6 years ago

This look good.

Could you please follow conventional changelog convention for your commit messages? It allows to generate an automatic changelog file.

Please use angular convention.

oupala commented 6 years ago

I tested your PR and it works well. I plan to merge it.

I see one problem: you are modifying one line, but you are also deleting 45 lines. Could you please restore these 45 lines so your pull request only modify one line?

Thanks.

oupala commented 6 years ago

Please update your pull request so that you try to merge to develop branch.

Thanks.

oupala commented 6 years ago

Although this pull request has been closed by its author, I've added this feature in commit 83cd4e20886b7f823ab4ca22e53b3ccd71b2a9f6.