Closed pollier closed 6 years ago
This look good.
Could you please follow conventional changelog convention for your commit messages? It allows to generate an automatic changelog file.
Please use angular convention.
I tested your PR and it works well. I plan to merge it.
I see one problem: you are modifying one line, but you are also deleting 45 lines. Could you please restore these 45 lines so your pull request only modify one line?
Thanks.
Please update your pull request so that you try to merge to develop
branch.
Thanks.
Although this pull request has been closed by its author, I've added this feature in commit 83cd4e20886b7f823ab4ca22e53b3ccd71b2a9f6.
Could you please fix conflicts of this pull reques so that I can merge it?